Created test for dnf over FTP protocol #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landgraf
reviewed
Jul 28, 2017
| /usr/bin/cp -u dummy.spec /run/fedora-networking/ | ||
| cd /run/fedora-networking | ||
|
|
||
| rpmbuild -ba dummy.spec |
There was a problem hiding this comment.
can we use something like:
rpmbuild --define "_topdir /var/run/fedora-networking" -ba dummy.spec
To keep ${HOME} clean?
| License: GPL+ | ||
| BuildArch: noarch | ||
|
|
||
| BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root |
There was a problem hiding this comment.
I can't remove the License, since the rpmbuild requires it, however I removed the other lines.
There was a problem hiding this comment.
I meant BuildRoot: tag only. So BuildArch should be there to keep from building for all arches.
|
|
||
| /usr/bin/cp -u \ | ||
| /root/rpmbuild/RPMS/noarch/dummy-rpm-1.0-1.noarch.rpm \ | ||
| /var/ftp/pub/fedora-networking |
There was a problem hiding this comment.
Same here. It'd be good to use /run/ for all testing related stuff (overriden vsftpd config?)
landgraf
suggested changes
Jan 29, 2018
| License: GPL+ | ||
| BuildArch: noarch | ||
|
|
||
| BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root |
There was a problem hiding this comment.
I meant BuildRoot: tag only. So BuildArch should be there to keep from building for all arches.
Undu deletion of the BuildArch.
|
I have added the BuildArch tag back, as you asked. I am sorry I misunderstood the previous request :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.